Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Added removal of meta attributes as claimed by docstring #615

Merged
merged 8 commits into from
Dec 9, 2020
Merged

BUG: Added removal of meta attributes as claimed by docstring #615

merged 8 commits into from
Dec 9, 2020

Conversation

rstoneback
Copy link
Collaborator

@rstoneback rstoneback commented Dec 7, 2020 •
edited
Loading

Description

Addresses #612

Meta attributes weren't removed from .Meta when transferred to the Instrument object as claimed by the docstring.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Modified unit tests to check for removal of attributes.

Test Configuration:

  • macOS 10.15.4
  • python 2

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@rstoneback rstoneback marked this pull request as ready for review December 9, 2020 02:58
aburrell
aburrell reviewed Dec 9, 2020
View reviewed changes
pysat/_meta.py Outdated Show resolved Hide resolved
pysat/tests/test_meta.py Outdated Show resolved Hide resolved
@rstoneback @aburrell
Apply suggestions from code review
03b24f5 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@rstoneback
Copy link
Collaborator Author

@aburrell ready for re-review when you are available.

@rstoneback rstoneback merged commit cbac6dd into develop-3 Dec 9, 2020
@rstoneback rstoneback deleted the meta_attrs_bug branch December 9, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rstoneback @aburrell