BUG/TST: support user and password kwargs in remote_file_list

[jklenzing]

Description

Addresses pysat/pysatMadrigal#5

Currently, user and password are not supported by the remote_file_list and remote_date_range methods. This updates the syntax to pass all kwargs through both routines.

Additionally, updates the test class to pass these through for packages like pysatMadrigal.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with the tst/remote_file_list branch of pysatMadrigal. See pysat/pysatMadrigal#38. Currently works with most of the methods there, but requires some bug fixes to some of the jro_isr data products.

import datetime as dt
import pysat
import pysatMadrigal as py_mad

dmsp_f13 = pysat.Instrument(inst_module=py_mad.instruments.dmsp_ivm, tag='utd', inst_id='f13')
dl_dict = {'user': 'your name here', 'password': 'email address'}
dmsp_f13.remote_file_list(**dl_dict)

Or, to test all routines in the pysatMadrigal home directory

pytest -vs pysatMadrigal/tests/test_instruments.py::TestInstruments::test_remote_file_list

Test Configuration:

• Python 3.8.2

Checklist:

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• [n/a] Add a note to CHANGELOG.md, summarizing the changes

[jklenzing]

Removed this since it reset the kwargs with the defaults rather than user-supplied options.

[aburrell]

The problem with talking this out is that it means that the user/password that you can set on instrument instantiation are no longer applied here. This needs to be changed to allow that, not removed.

[aburrell]

I'm making a change and testing it.

[aburrell]

@jklenzing I decided to prioritize kwargs supplied directly to the routine over those supplied to the Instrument.

[aburrell]

I fixed the thing that was broke, and it works as expected locally.

[jklenzing]

Tested this locally with the core package, as well as pysatMadrigal and pysatNASA. Everything is working as expected, with the exception of the three cases documented in pysatMadrigal. Looping in @rstoneback for a review.

[jklenzing]

Oops. Didn't see the approval. Thanks!