Added template instruments, related to Issues #94 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstoneback
changed the title
aburrell
reviewed
Oct 19, 2018
|
Review comments were incorporated. |
aburrell
approved these changes
Nov 5, 2018
User Experience Enhancements
automation
moved this from In progress
to Reviewer approved
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make adding new instruments easier.
Added a template for a general instrument, includes code for both xarray and pandas.
Uses pysat functions for list_files.
Added a template for using NASA CDAWeb methods. I expanded the download routine to include support for both sat_id and tag. Previously it only included tag. I updated associated instrument modules using CDAWeb methods.
Updated the supported instruments documentation. Trying a new section just for templates.
There is overlap between the template_instrument and the pre-existing netcdf4_pandas method. There is some distinction, the netcdf4 instrument can actually be used to load files. The template instrument docstrings are a bit more to the point. Perhaps a better basis to start a new instrument. I actually forgot about netcdf4_pandas until after I wrote this new template.