Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: testing syntax #39

Merged
merged 9 commits into from Dec 5, 2022
Merged

MAINT: testing syntax #39

merged 9 commits into from Dec 5, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Nov 8, 2022

Description

Addresses pysat/pysat#1053, pysat/pysat#1042, pysat/pysat#1048

  • Updates testing syntax to maintain pytest standards.
  • Updates Github Actions syntax
  • Removes nose requirements
  • restores changelog from previous version
  • Adds RC workflow

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Via Github Actions

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

CHANGELOG.md Show resolved Hide resolved
@jklenzing jklenzing mentioned this pull request Dec 1, 2022
3 tasks
@jklenzing
Copy link
Member Author

jklenzing commented Dec 1, 2022

Added a flake-8 cap to this branch since the latest version does not like how we invoke the ignore rules. Documented as part of standards upgrade in #43.

@jklenzing
Copy link
Member Author

Went ahead and added the RC check to close out issues at pysat. Results of test are here: https://github.com/pysat/pysatCDF/actions/runs/3594442005

Added #44 to capture the updating Github Actions to include windows and mac tests. Probably best for these to be implemented after or during meson upgrades to the install procedure.

@jklenzing jklenzing requested review from aburrell and removed request for aburrell December 5, 2022 16:18
@jklenzing jklenzing merged commit d117296 into develop-3 Dec 5, 2022
@jklenzing jklenzing deleted the tst/syntax branch December 5, 2022 16:25
@rstoneback
Copy link
Collaborator

Thanks @jklenzing and @aburrell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants