Geographic and Geodetic Coordinates

[rstoneback]

Compare the transformations here in pysat with those in pysatMagvect.

[jklenzing]

Are we migrating geographic/geodetic functions to pysatMagvect?

[rstoneback]

pysatMagVect already has its own geographic and geodetic transformations. I suppose we should pick one set and get rid of the other.

[jklenzing]

Are the transformations equivalent? I vote for keeping the coordinates in pysatMagVect (whichever algorithm we use).

[rstoneback]

No, they are not the same. Thanks for the vote. On Dec 18, 2019, at 4:41 PM, Jeff Klenzing <notifications@github.com> wrote:  Are the transformations equivalent? I vote for keeping the coordinates in pysatMagVect (whichever algorithm we use). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpysat%2Fpysat%2Fissues%2F167%3Femail_source%3Dnotifications%26email_token%3DAA3N26OEZXRQKKQMPUNTMWDQZKRIPA5CNFSM4GZC3AVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHXR7Y%23issuecomment-567245055&data=02%7C01%7Crstoneba%40utdallas.edu%7C240850f1b26b4c4d9d9f08d7840b61e3%7C8d281d1d9c4d4bf7b16e032d15de9f6c%7C0%7C0%7C637123056735285085&sdata=ah26R2jBtGFkkXoBzKCtI0hAN8wHOZ4sHGx09zmUBnw%3D&reserved=0>, or unsubscribe<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA3N26IHXF2E7GLC3QXRAH3QZKRIPANCNFSM4GZC3AVA&data=02%7C01%7Crstoneba%40utdallas.edu%7C240850f1b26b4c4d9d9f08d7840b61e3%7C8d281d1d9c4d4bf7b16e032d15de9f6c%7C0%7C0%7C637123056735295081&sdata=AJc1QYCNdXRNihxbbaMaNQ2H8JFTRAtvDT3tS36kqb0%3D&reserved=0>.

[jklenzing]

So which do we use?

[rstoneback]

Both. Depends upon application. Geodetic is good since it is the closest representation to actual Earth. But there are models with a spherical Earth (geographic) so we should support those as well.

[jklenzing]

I meant the pysatMagVect vs pysat algorithms, not geodetic vs geographic.

[rstoneback]

Ah, yes. Heh. The two methods use different algorithms and have different outputs. I think we should probably merge the two sets of methods together in pysat. We are in a bit of a weird position. More methods than is good to just have laying about yet not enough to really cover the general transformation problem and be its own package. On Dec 18, 2019, at 8:35 PM, Jeff Klenzing <notifications@github.com> wrote:  I meant the pysatMagVect vs pysat algorithms, not geodetic vs geographic. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpysat%2Fpysat%2Fissues%2F167%3Femail_source%3Dnotifications%26email_token%3DAA3N26ICISERFQCJG346Q63QZLMXNA5CNFSM4GZC3AVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIF63A%23issuecomment-567304044&data=02%7C01%7Crstoneba%40utdallas.edu%7Cd119cfc88cac4ca15aed08d7842c1ff9%7C8d281d1d9c4d4bf7b16e032d15de9f6c%7C0%7C0%7C637123197370226813&sdata=Blydb7kBfAYtpkSIU%2Fiywa3mDI%2B9D%2BBtIkJhtHOy9Pk%3D&reserved=0>, or unsubscribe<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA3N26PBYYO3E44BTT5RQZTQZLMXNANCNFSM4GZC3AVA&data=02%7C01%7Crstoneba%40utdallas.edu%7Cd119cfc88cac4ca15aed08d7842c1ff9%7C8d281d1d9c4d4bf7b16e032d15de9f6c%7C0%7C0%7C637123197370226813&sdata=oU72J52sy6PBvy8pGqJXiuyE36QVBkS71Y1ukHuivoc%3D&reserved=0>.

[jklenzing]

Functions under consideration

• geodetic_to_geocentric
• geodetic_to_geocentric_horizontal
• spherical_to_cartesian
• global_to_local_cartesian
• local_horizontal_to_global_geo

[jklenzing]

pysat meeting: move these functions to pysatMadrigal

[jklenzing]

TODO: Add deprecation warning into 2.2 for these functions.

[jklenzing]

• DeprecationWarnings for pysat 2.2.0 -- DEP: Add deprecation warnings for functions in coords pysat#453
• Remove functions for pysat 3.0.0 -- DEP: Remove coordinate transformations moved to pysatMadrigal pysat#455
• Add functions to pysatMadrigal -- ENH: Add Coordinate transformations from pysat #6

[jklenzing]

All changes should be addressed in the linked PRs above.

[jklenzing]

Since pysat pulls are done, moving this to pysatMadrigal.

[jklenzing]

Closing with merge of #6