-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add Coordinate transformations from pysat #6
Conversation
Documentation update
Updated failures to be more informative, allowing more intellegent error catches.
- Added new unit possibilities for velocity - Reduced the amount of time spent in initial for-loop
- Added tests for new functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style comments for cleaning up and parametrizing unit tests.
Fixed downstream use of `coords` to use local coordinate routine. Also fixed import order.
Pushed proposed structural changes for the geodetic to geocentric tests. If we are fully embracing parametrize, then the setup teardown class structure isn't needed. |
Marking as draft until group discussion on test styles for path forward |
Notes for moving forward:
|
failures due to changing pysat standards. Fixed in #15 |
Rewrite based on 8/12 discussion ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions applied to unit tests can be used in other unit test classes in the same file, reducing the number of lines.
import numpy as np | ||
|
||
from pysatMadrigal.instruments.methods import madrigal as mad_meth | ||
from pysat.instruments.methods import general as mm_gen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from pysat.instruments.methods import general as mm_gen | |
from pysat.instruments.methods import general as ps_gen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With appropriate changes made below.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Thanks for the suggestions! It's a lot cleaner now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's a lot easier for me to read now.
Addresses #7
Adds coordinate routines related to JRO from pysat. Includes pysat history for contribution credit.
Also adds a changelog