Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove unused kwarg #32

Merged
merged 2 commits into from
Dec 18, 2020
Merged

MAINT: remove unused kwarg #32

merged 2 commits into from
Dec 18, 2020

Conversation

aburrell
Copy link
Member

Removed unused kwarg fake_daily_files_from_monthly from list_files routine in all instruments.

Removed unused kwarg `fake_daily_files_from_monthly` from `list_files` routine in all instruments.
@aburrell aburrell mentioned this pull request Dec 15, 2020
10 tasks
@aburrell aburrell mentioned this pull request Dec 17, 2020
@jklenzing
Copy link
Member

According to coveralls, methods.filter_data_single_date has gone from covered to uncovered. Not sure why this is the case.

https://coveralls.io/builds/35740294/source?filename=pysatMadrigal%2Finstruments%2Fmethods%2Fmadrigal.py

@rstoneback
Copy link
Collaborator

jro_isr preprocess method still labeled default.

@rstoneback
Copy link
Collaborator

jro_isr preprocess method still labeled default.

I can't make a suggestion for a line that hasn't changed so I pushed a tiny commit to change the name.

@rstoneback
Copy link
Collaborator

jro_isr preprocess method still labeled default.

I can't make a suggestion for a line that hasn't changed so I pushed a tiny commit to change the name.

Since I made a push its also on me that it broke.
Current error is with download. I don't think that actually has anything to do with my change so tests are restarting.

@rstoneback
Copy link
Collaborator

jro_isr preprocess method still labeled default.

I can't make a suggestion for a line that hasn't changed so I pushed a tiny commit to change the name.

Since I made a push its also on me that it broke.
Current error is with download. I don't think that actually has anything to do with my change so tests are restarting.

Test failures are driven by the changes in meta labels, with the updates in #28.

Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aburrell!

@aburrell aburrell merged commit 991c73e into develop Dec 18, 2020
@aburrell aburrell deleted the update_list_files branch December 18, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants