Updated community documents #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pysat code of conduct.
Added guidelines for contributing to pysatMadrigal.
Added a zenodo json file.
Fixed bug when setting options in the setup.cfg file.
Added a pull request template.
Added issue templates for bugs, features, and questions.
Added a file manifest.
Removed unneeded line from the manifest.
Renamed testing requirements files to better describe their contents.
Updated travis to use requirements files.
rstoneback
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Thanks @aburrell. Looks good to me. I did raise a question for you to consider but I'll leave the outcome to you. Cheers.
| - [ ] My changes generate no new warnings | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes | ||
| - [ ] Any dependent changes have been merged and published in downstream modules |
There was a problem hiding this comment.
Should we still have a downstream check for a pysat* package?
Personally it seems to me that the check should be for upstream.
There was a problem hiding this comment.
Well, we can't break anything upstream, so I don't think we need a check there. While at the moment there isn't anything downstream from here, it's possible that analysis packages could rely on instrument methods in the future. So that is why I am keeping it here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing community documents, addressing #2. Also added a .zenodo.json file, updated setup configuration and travis.yml to comply with up-to-date methods used in pysatSpaceWeather.