-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load simple and multiple file types #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a load option for simple Madrigal data.
Fixed the limitation where only one type of file format could be listed at once.
Added a description of the changes to the changelog.
Added the missing pandas import.
Fixed spacing to conform with PEP8 requirements.
This was
linked to
issues
May 28, 2021
Closed
Re-add missing kwargs that were accidentally removed.
rstoneback
reviewed
May 28, 2021
Merged
STY: Added feedback
Added a general `list_files` routine for multiple file types.
Changed the individual instruments to use the general `list_files` routine.
Fixed the incorrect assignment of a routine variable name that would have overwritten another variable.
Fixed the mis-spelling of a module name.
rstoneback
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aburrell!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25 and #21.
This should load 2 days of data, one of which is from an HDF5 file, the other of which is from a simple.gz file.