ENH: updates GNSS tec documentation, methods testing #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the general load routine's definition of the meta data.
Replaced the VTEC figure while creating example text.
Updated the definitions of the VTEC metadata to remove load warnings.
Added an example for plotting VTEC maps to the docs.
Added unit tests for the GNSS methods routines.
Added description of these changes to the changelog.
Improved the style by removing unused imports and variables, as well as cleaning up whitespace.
aburrell
added
documentation
This was
linked to
issues
Sep 15, 2021
Updated the test class style by adding a class type and a `return` statement to all methods.
rstoneback
reviewed
Sep 16, 2021
| meta.labels.min_val: np.nan, meta.labels.max_val: np.nan} | ||
| meta['gdalt'] = {meta.labels.min_val: 0.0, meta.labels.max_val: np.nan} | ||
| meta['gdlat'] = {meta.labels.min_val: -90.0, meta.labels.max_val: 90.0} | ||
| min_lon = 0.0 if data['glon'].values.min() >= 0.0 else -180.0 |
There was a problem hiding this comment.
Do the longitudes differ across files?
There was a problem hiding this comment.
Not yet... but it seemed silly to not check for something that varies regularly from file iteration to file iteration and is very simple to verify.
|
Not required, and it probably makes the example too complicated for the docs, but |
Added `plt.show()` to a plotting example. Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Fixed a bug in the download example. Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
|
Yeah, I decided against it because I didn't want to figure out carteopy or get carteopy questions in the future 🗺️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the GNSS methods testing, adds a TEC example, and expands general Madrigal metadata definitions. Also fully defines the GNSS VTEC metadata. Partially addresses #3 and #41.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Created an example in the docs and added unit tests. You should also now receive no warning when loading VTEC data.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release