Apply suggestions from code review

Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
pysat · Aug 6, 2021 · 5608d99 · 5608d99
1 parent aed2c5d
commit 5608d99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pysatMissions/instruments/methods/orbits.py b/pysatMissions/instruments/methods/orbits.py
@@ -35,7 +35,7 @@ def _get_constants(planet='Earth'):
 
     Parameters
     ----------
-    planet : string
+    planet : str
         The name of the planet of interest.
         (default='Earth')
 
@@ -69,7 +69,7 @@ def convert_to_keplerian(alt_periapsis, alt_apoapsis=None, planet='Earth'):
     alt_apoapsis : float or NoneType
         The highest altitude from the mean planet surface along the orbit (km)
         If None, assumed to be equal to periapsis. (default=None)
-    planet : string
+    planet : str
         The name of the planet of interest.  Used for radial calculations and
         mass.
         (default='Earth')

diff --git a/pysatMissions/instruments/missions_sgp4.py b/pysatMissions/instruments/missions_sgp4.py
@@ -155,7 +155,7 @@ def load(fnames, tag=None, inst_id=None,
     epoch = (dates[0] - dt.datetime(1949, 12, 31)).days
     jd, _ = jday(dates[0].year, dates[0].month, dates[0].day, 0, 0, 0)
 
-    if inclination:
+    if inclination is not None:
         # If an inclination is provided, specify by Keplerian elements
         eccentricity, mean_motion = orbits.convert_to_keplerian(alt_periapsis,
                                                                 alt_apoapsis)