Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: pytest syntax #100

Merged
merged 2 commits into from Nov 3, 2022
Merged

MAINT: pytest syntax #100

merged 2 commits into from Nov 3, 2022

Conversation

jklenzing
Copy link
Member

Description

Addresses pysat/pysat#1053

updates pytest syntax (removes nose backwards-compatibility)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

github actions, checking coverage.

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing marked this pull request as ready for review November 2, 2022 20:34
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @jklenzing.

@jklenzing jklenzing merged commit fd3de78 into develop Nov 3, 2022
@jklenzing jklenzing deleted the tst/syntax branch November 3, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants