Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate v0.2.2 #54

Merged
merged 144 commits into from
Jun 18, 2021
Merged

Release Candidate v0.2.2 #54

merged 144 commits into from
Jun 18, 2021

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Jun 14, 2021 •
edited

Release candidate for version 0.2.2:

  • Update the version number
  • Verify and update Zenodo information in .zeondo.json
  • doc tests pass locally
  • activate this branch on readthedocs -- https://pysatmissions.readthedocs.io/en/rc_v0.2.2/
  • Upload the test distribution to the testPyPi server -- https://test.pypi.org/project/pysatMissions/0.2.2/
  • Contacted developers and users about the future release
  • [na] Performed integration tests with downstream packages (include list of these packages)
  • Create a wiki page with the release text - https://github.com/pysat/pysatMissions/wiki/v0.2.2
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

jklenzing and others added 30 commits September 30, 2020 11:22
@jklenzing
ENH: update sat_id to inst_id
a1fcabc
@jklenzing
DOC: update changelog
2f410d3
@jklenzing
DOC: update version
4e7c272
@jklenzing
Merge pull request #34 from pysat/maint/inst_id
d12243e 
MAINT: Use inst_id
@jklenzing
MAINT: remove pyglow
e4a4fe0
@jklenzing
BUG: remove IGRF
199980a
@jklenzing
MAINT: remove plot
36b7f33
@jklenzing
BUG: fix unit tests
5323ea0
@jklenzing
STY: flake8
27ff7ad
@jklenzing
STY: instrument standards
5fa174a
@jklenzing
STY: remove python 2.7 imports
30e5996
@jklenzing
MAINT: pysatMagVect to OMMBV - #19
eba5a51
@jklenzing
MAINT: update badges
c501d99
@jklenzing
TST: remove pyglow from tests
e02c238
@jklenzing
Back to pysatMagVect
da55bc5
@jklenzing
BUG: add path to travis CI
e59b37c
@jklenzing
STY: indentation
e021db3
@jklenzing
TST: update travis
6d22352
@jklenzing
REQ: update requirments
91dd575
@jklenzing
STY: typo
3613126
@jklenzing
STY: indentation
02688fb
@jklenzing
DOC: changelog
1f17f4f
@jklenzing
DOC: remove pyglow info from readme
e738d24
@jklenzing
DOC: update changelog
c23e439
@jklenzing
Merge pull request #37 from pysat/bug/remove_pyglow
3af6e6a 
BUG/TST: remove pyglow
@rstoneback
ENH: Updated to latest pysat custom method signature
aa5d0e0
@jklenzing
STY: use routines from pysat
6728004
@jklenzing
STY: standard clean
3ed70a1
@jklenzing
BUG: index
c32548a
@jklenzing
DOC: update docstring
9b342df
@jklenzing
Copy link
Member Author

jklenzing commented Jun 14, 2021 •
edited

Notes:

  • fortran installs not working with macos-latest on GA
  • Similar issues with older numpy versions
  • OMMBV requires manual install, not included in requirements.txt
  • Significant rewrites of both instruments expected with version 0.3.0

aburrell
aburrell reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a real style scrub. I think I got the worst of it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
pysatMissions/methods/spacecraft.py Outdated Show resolved Hide resolved
pysatMissions/methods/spacecraft.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@rstoneback @aburrell
Apply suggestions from code review
24f126c 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
rstoneback
rstoneback reviewed Jun 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
docs/tutorial.rst Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@jklenzing @rstoneback @aburrell
Apply suggestions from code review
63e90a4 
Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing jklenzing mentioned this pull request Jun 15, 2021
Closed
@jklenzing
Copy link
Member Author

Thanks for the reviews! Should be addressed or captured in new issues.

aburrell
aburrell reviewed Jun 16, 2021
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/supported_instruments.rst Outdated Show resolved Hide resolved
pysatMissions/instruments/missions_sgp4.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
rstoneback
rstoneback reviewed Jun 16, 2021
View reviewed changes
docs/supported_instruments.rst Show resolved Hide resolved
.github/workflows/main.yml
pip install -r test_requirements.txt
pip install -r requirements.txt
# Manual installs required
pip install --no-binary :OMMBV: OMMBV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new version of OMMBV has been released that passes unit tests with pysat 3.0. I also removed the line that was originally causing problems. OMMBV may not need special treatment anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly, still need special treatment. It doesn't want to get the new version for some reason. I'll fix it in the next version.

aburrell
aburrell reviewed Jun 16, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jklenzing @aburrell
Update CONTRIBUTING.md
39e7e44 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
aburrell
aburrell approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think the issues capture the problems we found that are out of scope here.

@jklenzing jklenzing merged commit 830c951 into main Jun 18, 2021
@jklenzing jklenzing deleted the rc_v0.2.2 branch August 11, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoneback rstoneback rstoneback left review comments

@aburrell aburrell aburrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jklenzing @rstoneback @aburrell