-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/ENH: sgp4 epoch #72
Conversation
@rstoneback, there may be a cleaner way of implementing this. |
if 'epoch' not in self.kwargs['load'].keys(): | ||
self.kwargs['load']['epoch'] = self.files.files.index[0] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this to set the default since I can't access self
in the load function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but looks good.
Co-authored-by: Russell Stoneback <github@stoneris.com>
Thanks @rstoneback! |
Description
Closes #67. Fixes a bug where sequential days have a large discontinuity in data when Keplerian elements are used.
Adds
epoch
kwarg tomissions_sgp4
instrument. The epoch is used to specify a datetime that corresponds to the Keplerian elements of the orbit used for propagation.If a user does not specify an epoch, it defaults to the start of the file range for the instrument.
epoch
will be set an instantiation.Type of change
How Has This Been Tested?
Using code in #67 and new unit tests.
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes -- fixes for previous pull in same version