Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: warning evaluation #93

Merged
merged 3 commits into from
Aug 5, 2022
Merged

MAINT: warning evaluation #93

merged 3 commits into from
Aug 5, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Aug 4, 2022 •
edited

Description

Addresses #82

Updates to use latest pysat test evaluation in deprecation warnings.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

via github actions

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing linked an issue Aug 4, 2022 that may be closed by this pull request
MAINT: warning evaluation #82
Closed
@jklenzing jklenzing added this to the 0.3.2 Release milestone Aug 4, 2022
@jklenzing
Copy link
Member Author

Decrease in coverage due to reduction in lines of code. New warnings coming from new pysat version, will solve downstream.

@jklenzing jklenzing marked this pull request as ready for review August 4, 2022 20:40
@jklenzing jklenzing merged commit 67cb969 into rc_0_3_2 Aug 5, 2022
@jklenzing jklenzing deleted the 82-maint-warning-evaluation branch August 5, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoneback rstoneback rstoneback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.2 Release
Development

Successfully merging this pull request may close these issues.

MAINT: warning evaluation
2 participants
@jklenzing @rstoneback