Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/BUG: remove unused test for match.collect_inst_model_pairs #32

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 2, 2020

Description

Unit tests currently check for an error message if no model is supplied. This error message should not be generated, so this test is removed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pytest -vs

Test Configuration:

  • Mac OS X 10.15.4
  • python 3.7.3

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing requested a review from aburrell April 2, 2020 14:53
@jklenzing jklenzing merged commit de2aab7 into develop Apr 2, 2020
@jklenzing jklenzing deleted the unit_tests_fix branch April 2, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants