Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale improvements #97

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Stale improvements #97

merged 6 commits into from
Feb 23, 2022

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Feb 22, 2022 •
edited

Description

This branch appears to be stale, but have some changes that could be worth merging into develop before creating a RC.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran existing unit tests

Test Configuration:

  • Operating system: OS X Big Sur
  • Version number: 3.9
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

rstoneback and others added 6 commits August 24, 2020 13:08
@rstoneback
BUG/STY: typo, method->methods. Coordinate selection code less specific.
94acb2d
@rstoneback
TEMP: Turned off longitude scaling. Need a scaling that is closed on …
63c9bb7 
…both ends, or optional presence. Adjusted custom call for running v2.2.1 pysat. pysat.Instrument()
@rstoneback
STY: Line breaks
a3e64a5
@aburrell
Merge branch 'develop' into rs_match_doc
d631b81
@aburrell
REV: reverted changes
098adc3 
Reverted changes made that break the routine.
@aburrell
BUG: fixed packaging import
aa062e5 
The packaging routine requires importing `version` from the packaging module.
@aburrell aburrell marked this pull request as ready for review February 22, 2022 21:05
@aburrell aburrell added this to the 0.2.0 milestone Feb 22, 2022
@aburrell aburrell merged commit 124cd7c into develop Feb 23, 2022
@aburrell aburrell deleted the rs_match_doc branch February 23, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoneback rstoneback rstoneback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aburrell @rstoneback