-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC/STY: formatting contributing page in docs #108
Conversation
Style should be consistent, EDIT: Needed to upgrade sphinx (>=4.3) to get the bullets to work for my local files. |
Also recommend adding ReadTheDocs to the CI checks. Would be especially useful for this PR. |
I see these are enabled in the pysat PRs, but don't see how to enable them in settings. |
I never remember how to do this, but I think it was as simple as adding a webhook in the settings. |
All the projects have the same webhook, but only pysat is actually linking in the CI checks. Tried deleting and reconfiguring here. |
Looks like it's a setting in readthedocs: "Build pull requests" under advanced settings. Reinstalling readthedocs since I broke the settings. |
Description
Addresses #106
Fixes the formatting of the contributing doc for RTD. Updates some info on the contributing page based on the latest pysat develop branch.
Minor formatting updates for the ICON EUV docstring and example code.
Type of change
How Has This Been Tested?
Inspection of the build page at RTD:
https://pysatnasa.readthedocs.io/en/sty-rtd/develop_guide/contributing.html
Also at the github level: https://github.com/pysat/pysatNASA/blob/sty/rtd/CONTRIBUTING.md
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes