Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test both pysatCDF and cdflib #116

Merged
merged 6 commits into from
May 18, 2022
Merged

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 4, 2022

Updates suggested for pysat/pysat#102.

  • Adds second round of tests to load with both pysatCDF and cdflib.
  • Fixes a bug where cdflib cannot be accessed in omni data

Requires pysat develop and pysatCDF RC. CI tests expected to fail.

@jklenzing jklenzing changed the title TST: optional pysatCDF TST: test both pysatCDF and cdflib May 4, 2022
@jklenzing
Copy link
Member Author

Local tests pass using above branches. Requires a slight modification to pysat as outlined in #172

@rstoneback
Copy link
Collaborator

Local tests pass for me as well, except for Gold, but that is already handled elsewhere. I ran tests with the load_meta_proc branch.

@jklenzing
Copy link
Member Author

jklenzing commented May 10, 2022

Note to self: running additional tests for cdf load can be streamlined in the next pysat release using the _test_load_opt notation.

@jklenzing
Copy link
Member Author

Doing a manual install of pysatCDF works, but this branch still requires changes in the develop branch of pysat.

@rstoneback
Copy link
Collaborator

Thanks for advancing things. Great to hear manual install works.

@jklenzing jklenzing added this to the 0.0.4 release milestone May 17, 2022
@jklenzing
Copy link
Member Author

Note to self: prioritize pysat/pysat#85 once pysat 3.0.2 is released. merge those back here to streamline.

@rstoneback
Copy link
Collaborator

I'm ok with merging this into pysat/pysat#102 whenever ready. They are in the same testing ⛵

@jklenzing jklenzing marked this pull request as ready for review May 17, 2022 21:36
@jklenzing jklenzing requested a review from rstoneback May 17, 2022 21:36
@jklenzing jklenzing merged commit cd5e3d5 into optional_pysatcdf May 18, 2022
@jklenzing jklenzing deleted the tst/pysatcdf branch May 18, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants