Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate v0.0.3 #117

Merged
merged 100 commits into from
May 18, 2022
Merged

Release Candidate v0.0.3 #117

merged 100 commits into from
May 18, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 16, 2022 •
edited

Description

Alpha release fully compatible with pysat 3.0.0+.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

This has been tested by running examples and unit tests locally

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.8.11
  • Any details about your local setup that are relevant: tested with pysat 3.0.0 and develop

Checklist:

  • Update the version number
  • Verify and update Zenodo information in .zeondo.json
  • doc tests pass locally
  • activate this branch on readthedocs: https://pysatnasa.readthedocs.io/en/rc_0_0_3/
  • Upload the test distribution to the testPyPi server: https://test.pypi.org/project/pysatNASA/0.0.3/
  • Contacted developers and users about the future release
  • Performed integration tests with downstream packages (include list of these packages) - na
  • Create a wiki page with the release text: https://github.com/pysat/pysatNASA/wiki/v0.0.3
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

jklenzing and others added 30 commits June 7, 2021 11:10
@jklenzing
Merge pull request #77 from pysat/main
1075169 
Capture latest changes from RC 0.0.2
@jklenzing
TST: windows CI tests
cd990a8
@jklenzing
TEMP: use pysat 3.0.1 rc in CI tests
5d89b5b
@jklenzing
DOC: update changelog
ea1c3c2
@jklenzing
BUG: pysat RC compatibility
bde3949
@jklenzing
STY: remove package build on doc testing
25ab252
@jklenzing
BUG: install for docs
b02210b
@jklenzing
DOC: update comments
9aef8f1
@rstoneback
BUG: Added cleaning to more IVM drift outputs
72653ff
@rstoneback
Merge branch 'develop' of https://github.com/pysat/pysatNASA into ico…
6dbf357 
…n_ivm_clean_bug
@rstoneback
DOC: Added note to changelog
9d40650
@jklenzing
Apply suggestions from code review
85e7210
@jklenzing
TST: update nep29 version to 1.18
2dbf3e9
@jklenzing
TST: restore pysat setup in docs
3714e18
@jklenzing
MAINT: remove separate pysat reqs
4a1c339
@jklenzing
Update requirements.txt
2b4a50e
@jklenzing
Merge pull request #80 from pysat/icon_ivm_clean_bug
bb84800 
BUG: ICON IVM Drifts Cleaning
@jklenzing
Merge branch 'develop' into tst/windows
a0ad0d1
@JonathonMSmith
update README for registry modification
50333f3
@jklenzing
Merge pull request #79 from pysat/tst/windows
72dcbb9 
TST: add windows tests
@JonathonMSmith
Merge branch 'pysat:main' into doc/readme
babcc8b
@JonathonMSmith
Merge remote-tracking branch 'upstream/develop' into doc/readme
c449e78
@JonathonMSmith
Merge branch 'doc/readme' of https://github.com/JonathonMSmith/pysatNASA
0e4d5ce 
 into doc/readme
@jklenzing
STY: docstrings
5fae2b6
@jklenzing
STY: docstrings
01c46cb
@jklenzing
STY: import order
b1e2da8
@jklenzing
STY: import order
4ed4988
@jklenzing
SY: class declaration
831f217
@jklenzing
STY: docstrings
a6e5fd1
@jklenzing
TST: add tests for style
e89ebed
@jklenzing jklenzing marked this pull request as ready for review May 16, 2022 18:38
@JonathonMSmith
Copy link
Collaborator

This is working really well on my windows machine!

aburrell
aburrell reviewed May 16, 2022
View reviewed changes
CHANGELOG.md
@@ -2,6 +2,21 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## [0.0.3] - 2022-05-16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimistic!

pysatNASA/instruments/templates/template_cdaweb_instrument.py Outdated Show resolved Hide resolved
@rstoneback
Copy link
Collaborator

Thanks @jklenzing for getting this RC up!!

I also checked this against load_meta_proc via unit tests. Everything passes but GOLD, and that fix is already somewhere.

Loading ICON data does produce a variety of UserWarnings related to meta. These are fixed in #100 but then the tests would fail until next pysat released (v3.0.2). Current thinking is I'll add a warnings.simplefilter to the summer school tutorials with ICON though of course happy to support merging of #100 into here if desired. Being on testpypi is enough for the summer school.

@rstoneback
Copy link
Collaborator

After more thought the warnings do provide an opportunity to demonstrate some of the internal checks pysat has. No need for stress on this one.

JonathonMSmith
JonathonMSmith reviewed May 17, 2022
View reviewed changes
pysatNASA/instruments/templates/template_cdaweb_instrument.py Outdated
@@ -145,7 +180,7 @@ def default(self):

# code should be defined below as needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate with line 164, may be unneeded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the prior line, since preprocess is still part of the standard bits

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added it back, since this is needed in both locations. That will teach me not to look at the full code.

@jklenzing @aburrell @rstoneback
Apply suggestions from code review
848e013 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
@jklenzing
Copy link
Member Author

Thanks @jklenzing for getting this RC up!!

I also checked this against load_meta_proc via unit tests. Everything passes but GOLD, and that fix is already somewhere.

Loading ICON data does produce a variety of UserWarnings related to meta. These are fixed in #100 but then the tests would fail until next pysat released (v3.0.2). Current thinking is I'll add a warnings.simplefilter to the summer school tutorials with ICON though of course happy to support merging of #100 into here if desired. Being on testpypi is enough for the summer school.

I suspect I'll wind up pushing another patch once pysat 3.0.2 is officially released. That's holding back multiple pulls at this point. But we might as well get the bug fixes out now.

rstoneback
rstoneback reviewed May 17, 2022
View reviewed changes
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some small formatting stuff.

docs/installation.rst Show resolved Hide resolved
pysatNASA/instruments/de2_wats.py Show resolved Hide resolved
pysatNASA/instruments/iss_fpmu.py Show resolved Hide resolved
pysatNASA/instruments/omni_hro.py Show resolved Hide resolved
pysatNASA/instruments/templates/template_cdaweb_instrument.py Show resolved Hide resolved
pysatNASA/instruments/methods/_cdf.py Show resolved Hide resolved
pysatNASA/instruments/methods/cdaweb.py Show resolved Hide resolved
@jklenzing jklenzing requested a review from rstoneback May 17, 2022 19:56
rstoneback
rstoneback approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jklenzing!

@jklenzing jklenzing added this to the 0.0.3 release milestone May 17, 2022
@jklenzing jklenzing merged commit d2ffb67 into main May 18, 2022
@jklenzing jklenzing deleted the rc_0_0_3 branch November 2, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoneback rstoneback rstoneback approved these changes

@JonathonMSmith JonathonMSmith JonathonMSmith approved these changes

@aburrell aburrell Awaiting requested review from aburrell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.3 release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jklenzing @JonathonMSmith @rstoneback @aburrell