-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STY: reduce duplication for init and clean #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 18, 2022
Topics to discuss:
|
jklenzing
commented
May 19, 2022
I've decided this pull is large enough for review. Follow-on work to update other instruments documented in #119, including consistency issues that are out of scope here. |
aburrell
reviewed
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the smaller pull request! 🐴
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
aburrell
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #89, #118
Adds two general instrument methods which are frequently repeated:
init
, where the initialization routine reads from a standard mission-level module (cnofs, de2, icon)clean_warn
, a custom clean routine that warns users that cleaning is not availableAdditionally, suppresses logger messages during package-level imports of constellation objects. This is required to keep the logger from being saturated until this issue is fixed at the pysat-level. Otherwise verifying the logger here is near-impossible.
Type of change
How Has This Been Tested?
acknowledgement string should go to the logger, and ivm.acknowledgements and ivm.references updated accordingly.
Can be repeated for the cnofs, de2, and icon instruments
For cleaning, attempt to load de2 data, look for the warning.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes