STY: streamline cdf tests, NEP 29 update July 2022

[jklenzing]

Description

• Improves use_cdfib syntax to reduce number of skipped tests.
  • Check if instruments use cdf before deploying test_load_cdflib.
  • Reduce the number of skipped tests since netCDF instruments are excluded before parametrize is run.
  • Remove clean_level tests for test_load_cdflib since those are post-processing and tested elsewhere. Since cdflib is the slower option, this speeds things up a bit.
• Bumps minimum NEP29 version to 1.20
• Adds xarray cap for incompatibilities with numpy 1.20
• Uses verbose pytest in Github Actions to get feedback on skipped tests

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested via pytest.

Test Configuration

• Python 3.8.11
• Mac OS X Big Sur
• The usual tests at Github Actions

Checklist:

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• Add a note to CHANGELOG.md, summarizing the changes (part of previous pull, pysatCDF)
• Update zenodo.json file for new code contributors

[rstoneback]

what about version limits in setup.cfg?

[jklenzing]

what about version limits in setup.cfg?

I thought these were not supposed to go in setup.cfg. @aburrell?

[rstoneback]

I've been seeing xarray 2020.06.0 on systems, like the testing here, that I was expecting would have a previous xarray version given the dependence on pysat.

I just checked pysat. There are no version restrictions within the setup so default pysat installations are installing the newest xarray which is incompatible 😿

[aburrell]

I thought these were not supposed to go in setup.cfg

That is correct, it's an antipattern.

[jklenzing]

So if we install from pip, how does it know which versions will work?

[jklenzing]

Documentation tests fixed in #122. Note that the xarray cap is only in the NEP29 tests, since it does not support numpy 1.20.

[jklenzing]

xarray limit only required for NEP29 case.

[rstoneback]

do we still need this restriction?

[jklenzing]

We need this for the NEP29 case since the old numpy is not compatible with the latest xarray.