Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add DE2 instruments #155

Merged
merged 34 commits into from
Apr 4, 2023
Merged

ENH: Add DE2 instruments #155

merged 34 commits into from
Apr 4, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 3, 2023

Description

Addresses #61

Adds support for VEFI, Mag, and FPI instruments on board DE2. NOTE that Mag data only available as part of VEFI dataset.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

with pytest

Test Configuration

  • Operating system: Mac Monterrey
  • Version number: python 3.10.8

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing marked this pull request as ready for review April 4, 2023 14:45
Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@@ -26,7 +26,7 @@
spectrum; and the concentration of H+, He+, O+, and Fe+, and of molecular ions
near perigee.

It includes the DUCT portion of the high resolutiondata from the Dynamics
It includes the DUCT portion of the high resolution data from the Dynamics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does DUCT mean? When I tried looking this up all I found was that this RPA has "a separate wide aperture sensor, a duct sensor"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's an acronym or just a name that's been capitalized (like MAG). I might need to drop this info since we don't include the duct files, which require an xarray load.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these lines since duct is not yet supported

@jklenzing jklenzing merged commit 2bdcd8b into develop Apr 4, 2023
16 checks passed
@jklenzing jklenzing deleted the enh/de2 branch April 4, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants