-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add DE2 instruments #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
pysatNASA/instruments/de2_rpa.py
Outdated
@@ -26,7 +26,7 @@ | |||
spectrum; and the concentration of H+, He+, O+, and Fe+, and of molecular ions | |||
near perigee. | |||
|
|||
It includes the DUCT portion of the high resolutiondata from the Dynamics | |||
It includes the DUCT portion of the high resolution data from the Dynamics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does DUCT mean? When I tried looking this up all I found was that this RPA has "a separate wide aperture sensor, a duct sensor"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's an acronym or just a name that's been capitalized (like MAG). I might need to drop this info since we don't include the duct files, which require an xarray load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these lines since duct is not yet supported
Description
Addresses #61
Adds support for VEFI, Mag, and FPI instruments on board DE2. NOTE that Mag data only available as part of VEFI dataset.
Type of change
How Has This Been Tested?
with pytest
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes