Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Formosat update #18

Merged
merged 1 commit into from
Oct 16, 2020
Merged

STY: Formosat update #18

merged 1 commit into from
Oct 16, 2020

Conversation

jklenzing
Copy link
Member

Addresses #2. Renames 'rocsat1' as 'formosat1' in keeping with community conventions.

@jklenzing jklenzing marked this pull request as ready for review October 8, 2020 21:33
JonathonMSmith
JonathonMSmith approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tried searching through the branch for mentions of rocsat and only saw it in the references which shouldn't change.

@jklenzing jklenzing merged commit e080a43 into develop Oct 16, 2020
@jklenzing jklenzing deleted the sty/formosat branch October 16, 2020 12:45
@jklenzing jklenzing mentioned this pull request Oct 16, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathonMSmith JonathonMSmith JonathonMSmith approved these changes

@rstoneback rstoneback Awaiting requested review from rstoneback

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jklenzing @JonathonMSmith