Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: decode times kwarg #191

Merged
merged 3 commits into from
Jun 14, 2023
Merged

MAINT: decode times kwarg #191

merged 3 commits into from
Jun 14, 2023

Conversation

jklenzing
Copy link
Member

Description

Addresses #189

Specifies a default for decode_times to maintain current behavior.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Loading data for xarray netCDF instruments

Test Configuration

  • Operating system: Monterrey
  • Version number: Python 3.10.9

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing marked this pull request as ready for review June 13, 2023 21:30
@jklenzing jklenzing requested review from JonathonMSmith and removed request for aburrell June 13, 2023 21:31
@jklenzing jklenzing linked an issue Jun 13, 2023 that may be closed by this pull request
MAINT: usage of decode_times kwarg #189
Closed
@jklenzing jklenzing added this to the 0.0.5 Release milestone Jun 13, 2023
@jklenzing jklenzing requested a review from aburrell June 14, 2023 12:22
aburrell
aburrell reviewed Jun 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jklenzing @aburrell
Update CHANGELOG.md
ab93499 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing jklenzing requested a review from aburrell June 14, 2023 15:29
@jklenzing jklenzing merged commit 5b0654e into develop Jun 14, 2023
20 of 21 checks passed
@jklenzing jklenzing deleted the sty/decode_times branch June 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell approved these changes

@t-esman t-esman Awaiting requested review from t-esman

@JonathonMSmith JonathonMSmith Awaiting requested review from JonathonMSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.5 Release
Development

Successfully merging this pull request may close these issues.

MAINT: usage of decode_times kwarg
2 participants
@jklenzing @aburrell