Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up code #7

Merged
merged 3 commits into from
Sep 22, 2019
Merged

Tidy up code #7

merged 3 commits into from
Sep 22, 2019

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Sep 22, 2019

Description

Updates the setup requirements following the examples of the other codes. Also updates readme and descriptions.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change is a documentation update

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing added this to the 0.1.0 release milestone Sep 22, 2019
@jklenzing
Copy link
Member Author

Added matplotlib back in since this will not be a requirement for pysat 3.0.0. Save us a few headaches in the future.

@rstoneback
Copy link
Collaborator

Looks good.

@jklenzing jklenzing merged commit 849acf8 into develop Sep 22, 2019
@jklenzing jklenzing deleted the tidy_up_code branch September 22, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants