Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow venv_install in config file #680

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Allow venv_install in config file #680

merged 4 commits into from
Nov 28, 2022

Conversation

abravalheri
Copy link
Collaborator

Purpose

Workaround INI limitation on list data structures for venv_install.

Closes #679

Approach

  • Split value if venv_install is a string.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 97.847% when pulling 048c4bc on fix-config into 9069f04 on master.

FlorianWilhelm
FlorianWilhelm approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@FlorianWilhelm FlorianWilhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @abravalheri! :-)

@abravalheri abravalheri merged commit c7a3da2 into master Nov 28, 2022
@abravalheri abravalheri deleted the fix-config branch November 28, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianWilhelm FlorianWilhelm FlorianWilhelm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow venv_install to be specified in config file.
3 participants
@abravalheri @coveralls @FlorianWilhelm