Skip to content

Commit

Permalink
Specify virtualenv as extra dependency for build in tox.ini
Browse files Browse the repository at this point in the history
`build` seems to rely by default in the stdlib's implementation of `venv`
and unfortunately for a specific combination of Windows + conda env + virtualenv (as used by tox),
that might be problematic as identified in pyscaffold/pyscaffoldext-markdown#10.

According to the discussion in pypa/build#253,
specifying `virtualenv` as an extra dependency of `build` seems to be a
good workaround. Moreover I would expect some kind speed improvements
(virtualenv is reported to be faster than venv).
  • Loading branch information
abravalheri committed Mar 9, 2021
1 parent a89f479 commit 5d0b101
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/pyscaffold/templates/tox_ini.template
Expand Up @@ -30,7 +30,7 @@ description =
skip_install = True
changedir = {toxinidir}
deps =
build: build
build: build[virtualenv]
commands =
clean: python -c 'from shutil import rmtree; rmtree("build", True); rmtree("dist", True)'
build: python -m build .
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Expand Up @@ -52,7 +52,7 @@ description =
skip_install = True
changedir = {toxinidir}
deps =
build: build
build: build[virtualenv]
commands =
clean: python -c 'from shutil import rmtree; rmtree("build", True); rmtree("dist", True)'
build: python -m build .
Expand Down

0 comments on commit 5d0b101

Please sign in to comment.