Skip to content

Commit

Permalink
Remove redundant wheel dep from pyproject.toml
Browse files Browse the repository at this point in the history
Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9
  • Loading branch information
mgorny authored and abravalheri committed Jun 25, 2022
1 parent f06fc4c commit d616845
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
1 change: 1 addition & 0 deletions AUTHORS.rst
Expand Up @@ -23,3 +23,4 @@ Contributors
* Noah Pendleton
* John Vandenberg
* Ben Mares
* Micha艂 G贸rny
6 changes: 1 addition & 5 deletions src/pyscaffold/dependencies.py
Expand Up @@ -8,7 +8,7 @@

# setuptools version is now enforced via `install_requires`

BUILD = ("setuptools_scm>=5", "wheel")
BUILD = ("setuptools_scm>=5",)
"""Dependencies that will be required to build the created project"""
RUNTIME = ('importlib-metadata; python_version<"3.8"',)
# TODO: Remove `importlib-metadata` when `python_requires = >= 3.8`
Expand All @@ -22,10 +22,6 @@
# version 46.1.0 fix a bug with setuptools.finalize_distribution_options,
# which is a hook used by setuptools_scm (better safe then sorry).

# TODO: Maybe specify a min version for wheel?
# For the time being, there is an issue preventing us to do that:
# https://github.com/pypa/pep517/issues/86

REQ_SPLITTER = re.compile(r";(?!\s*(python|platform|implementation|os|sys)_)", re.M)
"""Regex to split requirements that considers both `setup.cfg specs`_ and `PEP 508`_
(in a *good enough* simplified fashion).
Expand Down
2 changes: 1 addition & 1 deletion tests/system/test_common.py
Expand Up @@ -38,7 +38,7 @@ def test_ensure_inside_test_venv(putup):
assert ".tox" in putup


BUILD_DEPS = ["wheel", "setuptools_scm"]
BUILD_DEPS = ["setuptools_scm"]


def test_putup(cwd, putup):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_update.py
Expand Up @@ -331,7 +331,7 @@ def pyproject_from_old_extension(tmpfolder):
"""Old pyproject.toml file as produced by pyscaffoldext-pyproject"""
config = """\
[build-system]
requires = ["setuptools", "wheel"]
requires = ["setuptools"]
"""
pyproject = Path(tmpfolder) / "pyproject.toml"
pyproject.write_text(dedent(config))
Expand Down

0 comments on commit d616845

Please sign in to comment.