Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support in PyScaffold v3.1 #177

Closed
FlorianWilhelm opened this issue Jun 13, 2018 · 5 comments
Closed

Drop Python 2 support in PyScaffold v3.1 #177

FlorianWilhelm opened this issue Jun 13, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@FlorianWilhelm
Copy link
Member

PyScaffold is a tool for creating new Python projects and Python 3 surely has been for quite a while the right version to start a new project. Also due the a bug in setuptools the current version 3.0 of PyScaffold has no Python 2 support right now and there were no complaints about this.
We could officially drop the Python 2 support in PyScaffold 3.1 and get rid of six, unnecessary __future__ imports in templates and the code of PyScaffold itself. This would clean things up.

@abravalheri
Copy link
Collaborator

To be sincere, since the test suite is intrinsically broken with 2.7, all the last changes might be incompatible anyway...

@FlorianWilhelm
Copy link
Member Author

Okay, sounds like we have a decision then ;-)

abravalheri added a commit to abravalheri/pyscaffold that referenced this issue Jun 18, 2018
The old format is not valid anymore.
Additionally remove any python 2.7 env (not supported), see pyscaffold#177.
@FlorianWilhelm FlorianWilhelm added this to the v3.1 milestone Jun 18, 2018
@FlorianWilhelm
Copy link
Member Author

Since we have never had Python 2 support in version 3.0 we can drop it in version 3.1 officially without violating semantic version. I wouldn't want to wait for version 4.0 for that.

abravalheri added a commit to abravalheri/pyscaffold that referenced this issue Jun 18, 2018
The old format is not valid anymore.
Additionally remove any python 2.7 env (not supported), see pyscaffold#177.
FlorianWilhelm pushed a commit that referenced this issue Jun 18, 2018
The old format is not valid anymore.
Additionally remove any python 2.7 env (not supported), see #177.
@FlorianWilhelm FlorianWilhelm added the enhancement New feature or request label Jun 18, 2018
@FlorianWilhelm
Copy link
Member Author

Since the six and all __future__ imports where removed this ticket can be closed. As we go we should start using more Python 3 features and make things even more pythonic.

@abravalheri
Copy link
Collaborator

abravalheri commented Jul 12, 2018

Unfortunately we have to wait 3.6 to be the base line to use f-strings 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants