Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp --gitlab extension #622

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Revamp --gitlab extension #622

merged 2 commits into from
Mar 10, 2022

Conversation

abravalheri
Copy link
Collaborator

The previous version of the template for the GitLab CI was added to PyScaffold a while ago and never revised.

Although it seems that it was working (surprisingly), it also didn't offer the same features as CirrusCI or the proposed GitHub Actions.

This change is a revamp on that template that tries to offer more or less the same level of functionality our other CI configs offer.

It was tested against a replica of the ci-tester repository on GitLab:

This is the pipeline output:

The previous version of the template for the GitLab CI was added to
PyScaffold a while ago and never revised.

Although it seems that it was working (surprisingly), it also didn't
offer the same features as CirrusCI or the proposed GitHub Actions.

This change is a revamp on that template that tries to offer more or
less the same level of functionality our other CI configs offer.

It was tested against a replica of the `ci-tester` repository on GitLab:

- https://gitlab.com/pyscaffold/ci-tester

This is the pipeline output:

- https://gitlab.com/pyscaffold/ci-tester/-/commit/e8e3a777b972bc839a9b32d7c0c0678184ef2756
@abravalheri abravalheri mentioned this pull request Mar 8, 2022
4 tasks
@abravalheri abravalheri added this to the 4.2 milestone Mar 8, 2022
@abravalheri
Copy link
Collaborator Author

Maybe in the future we want to change the flag from --gitlab to --gitlab-ci...
I fear that having it named --gitlab might influence people that are hosting the code on GitLab to use that flag, even if they would prefer having other CI provider (e.g. Cirrus)

@coveralls
Copy link

coveralls commented Mar 8, 2022

Pull Request Test Coverage Report for Build 6248672097730560

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 97.436%

Totals Coverage Status
Change from base Build 6690009053921280: 0.006%
Covered Lines: 1691
Relevant Lines: 1725

💛 - Coveralls

Copy link
Member

@FlorianWilhelm FlorianWilhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abravalheri! LGTM :-)

@abravalheri
Copy link
Collaborator Author

Thank you very much for the review @FlorianWilhelm!

@abravalheri abravalheri merged commit 158e5df into master Mar 10, 2022
@abravalheri abravalheri deleted the revamp-gitlab-ci branch March 10, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants