Revamp --gitlab extension
#622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version of the template for the GitLab CI was added to PyScaffold a while ago and never revised. Although it seems that it was working (surprisingly), it also didn't offer the same features as CirrusCI or the proposed GitHub Actions. This change is a revamp on that template that tries to offer more or less the same level of functionality our other CI configs offer. It was tested against a replica of the `ci-tester` repository on GitLab: - https://gitlab.com/pyscaffold/ci-tester This is the pipeline output: - https://gitlab.com/pyscaffold/ci-tester/-/commit/e8e3a777b972bc839a9b32d7c0c0678184ef2756
Collaborator
Author
|
Maybe in the future we want to change the flag from |
Pull Request Test Coverage Report for Build 6248672097730560
💛 - Coveralls |
FlorianWilhelm
approved these changes
Mar 10, 2022
Member
FlorianWilhelm
left a comment
FlorianWilhelm
left a comment
There was a problem hiding this comment.
Thanks, @abravalheri! LGTM :-)
Collaborator
Author
|
Thank you very much for the review @FlorianWilhelm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the template for the GitLab CI was added to PyScaffold a while ago and never revised.
Although it seems that it was working (surprisingly), it also didn't offer the same features as CirrusCI or the proposed GitHub Actions.
This change is a revamp on that template that tries to offer more or less the same level of functionality our other CI configs offer.
It was tested against a replica of the
ci-testerrepository on GitLab:This is the pipeline output: