Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP621: Move more configuration into pyproject.toml #698

Merged
merged 3 commits into from Feb 21, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 19, 2023

Purpose

Describe the problem or feature in addition to a link to the issues.
Related to the discussion in #256

Use ini2toml to migrate more configuration to pyproject.toml and run validate-pyproject to validate results.

  • Currently flake8 is not yet compatible with pyproject.toml so move its config to .flake8

Approach

How does this change address the problem?
% ini2toml setup.cfg | pbcopy
% code pyproject.toml setup.cfg
% git mv setup.cfg .flake8
% validate-pyproject pyproject.toml

Valid file: pyproject.toml

Open Questions and Pre-Merge TODOs

  • Use GitHub checklists. When solved, check the box and explain the answer.

Resources & Links

Links to blog posts, patterns, libraries or add-ons used to solve this problem

@abravalheri
Copy link
Collaborator

Thank you very much @cclauss, I rebased this one on top of the latest changes.

@abravalheri abravalheri changed the base branch from master to dev February 20, 2023 14:31
@abravalheri
Copy link
Collaborator

abravalheri commented Feb 20, 2023

I am also changing the target to the dev branch.

We can start preparing for the v6 version on the dev branch which should be focused in the latest pyproject.toml experience.

I have to admit I am very delayed with that 😝, still have to find the time to implement the other required changes...

@coveralls
Copy link

Coverage Status

Coverage: 97.78%. Remained the same when pulling b3cbba5 on cclauss:PEP621-more-pyproject.toml into c0a5f97 on pyscaffold:dev.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 20, 2023

Impressive!

@abravalheri abravalheri merged commit f9205c3 into pyscaffold:dev Feb 21, 2023
@abravalheri
Copy link
Collaborator

I merged this into dev, officially starting the works on v6 (hopefully I will have some time to dedicate to that).

@cclauss cclauss deleted the PEP621-more-pyproject.toml branch February 21, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants