Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Github Token variable in template. #715

Merged

Conversation

victorgarcia98
Copy link
Contributor

Hello!

Running pyscaffold with the the Github Actions flag I've encountered that It fails to upload the code coverage report. By default, GitHub exposes the Github Token through the variable secrets.GITHUB_TOKEN in upper case, while in the template it is used in lower case secrets.github_token.

Thanks,
Víctor

Signed-off-by: victor <victor@seita.nl>
@coveralls
Copy link

Coverage Status

Coverage: 97.847%. Remained the same when pulling 1d34e97 on victorgarcia98:github_token_capitalization into 83c7d5d on pyscaffold:master.

@victorgarcia98 victorgarcia98 changed the title Changing `Github Token variable in template. Changing Github Token variable in template. Apr 17, 2023
@abravalheri
Copy link
Collaborator

Thank you very much @victorgarcia98

@abravalheri abravalheri merged commit 51ccd4a into pyscaffold:master Apr 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants