Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-virtualenv and related (not compatible with Python 3.12) #723

Merged
merged 10 commits into from Jun 20, 2023

Conversation

abravalheri
Copy link
Collaborator

Purpose

The latest runs of the CI has been failing in Python 3.12, due to the usage of a removed module (imp) in pythest-virtualenv and friends.

Approach

It seems that the pythest-virtualenv is not that much active nowadays, so maybe the best is to simply drop it and implement something else in its place.

The coverage bit is the tricky part. I hope I got it right.

Resources & Links

Links to blog posts, patterns, libraries or addons used to solve this problem

@coveralls
Copy link

coveralls commented Jun 19, 2023

Coverage Status

coverage: 97.936%. remained the same when pulling bf39767 on remove-pytest-virtualenv into a51dcf4 on master.

@abravalheri abravalheri merged commit 98396ca into master Jun 20, 2023
20 checks passed
@abravalheri abravalheri deleted the remove-pytest-virtualenv branch June 20, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants