Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in documentation #19

Merged
merged 2 commits into from Jul 9, 2019
Merged

Conversation

abravalheri
Copy link
Contributor

As I am a lazy person, I bundled togheter 2 changes in only one PR. Please let me know if you want me to split it so the first one can be accepted without the second.

  1. Fix extension flag on README (package instead of project)
  2. In the README description, the following example is given:
    putup --custom-extension notebooks
    However this throws an error in the current implementation.
    The changes in this commit address that by adding the prefix by default and warning the user instead of raising an exception.

In the README description, the following example is given:

   putup --custom-extension notebooks

However this throws an error in the current implementation.

The changes in this commit address that by adding the prefix by default
and warning the user instead of raising an exception.
@abravalheri abravalheri changed the title Small improvements Fix inconsistencies in documentation Jul 9, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 132

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.1%) to 96.129%

Files with Coverage Reduction New Missed Lines %
.tox/default/lib/python3.6/site-packages/pyscaffoldext/custom_extension/extension.py 2 96.83%
Totals Coverage Status
Change from base Build 130: 2.1%
Covered Lines: 138
Relevant Lines: 142

💛 - Coveralls

@FlorianWilhelm FlorianWilhelm merged commit f22a015 into master Jul 9, 2019
@FlorianWilhelm
Copy link
Member

@abravalheri Thanks for your improvements!

@abravalheri abravalheri deleted the small-improvements branch January 21, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants