Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to no-guess-dev versioning #46

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Change to no-guess-dev versioning #46

merged 1 commit into from
Jan 11, 2022

Conversation

FlorianWilhelm
Copy link
Member

@abravalheri, was there a reason we had post-version in this extension?

@abravalheri
Copy link
Contributor

Thank you very much @FlorianWilhelm for spotting this!

If I remember correctly when we were migrating from v3 to v4, there was a short period of time that no-guess-dev was not an allowed value (?), so I ended up using post-version during the transition...

By the way, is setuptools-scm still recommending not to use no-guess-dev?

@abravalheri abravalheri self-requested a review January 5, 2022 09:24
@abravalheri
Copy link
Contributor

The CI seems to be a bit confused, but everything should be fine if we run it again...

@FlorianWilhelm
Copy link
Member Author

FlorianWilhelm commented Jan 5, 2022

The recommendation is still not to use no-guess-dev as it brings no smart version guessing. @RonnyPfannschmidt and I agreed that the other version schemes are much better if you are a professional software developer working on a professionally set up project with release and git workflows. On the other hand, we also agreed on the fact that users of PyScaffold might be overwhelmed with what you need to do in the sense of git workflows to really benefit from setuptools-scm's smarter version schemes. For this reason we stick to no-guess-dev but mention in the template that there are smarter version schemes to check out. I already pushed a commit with this change to PyScaffold between the years.

@abravalheri
Copy link
Contributor

Thank you very much for the clarification!

@RonnyPfannschmidt
Copy link

Reminds me, i need to release a breaking version of setuptools_scm that makes no guess dev smarter

@FlorianWilhelm FlorianWilhelm merged commit f900101 into master Jan 11, 2022
@FlorianWilhelm FlorianWilhelm deleted the version-scheme branch January 11, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants