Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 #116

Open
wants to merge 194 commits into
base: master
Choose a base branch
from
Open

Version 3 #116

wants to merge 194 commits into from

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Dec 27, 2021

This version enables a major restructure of code. The key ideas behind the restructure of the code base are:

  • Reduce the memory used by pyscal. Currently atom objects are C++ based. There are always copied for each calculation. The atom objects should be removed, and replaced with a Python object so that it can be directly interacted with.
  • Reduce C++ code. To easily maintain the code, C++ side should be reduced to a set of methods for the time critical parts. The rest of the code should be on the python side.

Check list for merge

Basic features

  • natoms
  • concentration
  • box
  • atoms
  • add_atoms
  • repeat
  • read_file
  • to_file
  • to_ase
  • extract cubic box
  • show
  • custom lattice creation (add custom lattice creation #138)
  • Rotation
  • Slicing
  • GBs

Neighbor methods

Steinhardt

Solid

Misc

Other modules

  • Traj process
  • crystal structures
  • Trajectory

Others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants