Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a compat package to additionally allow import from "evtk" #10

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

renefritze
Copy link
Contributor

This is the compat library I propose in #7

Copy link
Collaborator

@somada141 somada141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xylar
Copy link
Collaborator

xylar commented Mar 15, 2019

This looks great!

@xylar xylar marked this pull request as ready for review March 15, 2019 23:44
@xylar
Copy link
Collaborator

xylar commented Mar 15, 2019

It looks like this needs to be rebased onto the current master. There's a conflicts in tests/dummy.py.

@codecov-io
Copy link

codecov-io commented Mar 17, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   70.71%   70.71%           
=======================================
  Files           5        5           
  Lines         519      519           
=======================================
  Hits          367      367           
  Misses        152      152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5dabf7...c2a71f8. Read the comment docs.

@renefritze renefritze merged commit 11a1e70 into master Mar 17, 2019
@renefritze renefritze deleted the compat_package branch March 17, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants