Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should detect and throw an error if two scripts pointing to pyscript.js are found #1010

Closed
3 tasks done
FabioRosado opened this issue Dec 2, 2022 · 2 comments
Closed
3 tasks done
Labels
needs-triage Issue needs triage

Comments

@FabioRosado
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a duplication
  • I already searched in Google and didn't find any good information or help

What is the issue/comment/problem?

This issue is based on Antonio's suggestion on this line.

For context, I've noticed some weird behaviour when by mistake added two pyscriptjs script tags. The splashscreen errored out in a strange way because the element was already created.

Ideally we should detect if the user has two script tags pointing to pyscriptjs and throw an error saying that one should be removed.

@FabioRosado FabioRosado added the needs-triage Issue needs triage label Dec 2, 2022
@madhur-tandon
Copy link
Member

+1 to this issue

@WebReflection
Copy link
Contributor

late to the party ... current PyScript is based on sticky-module exactly to address these cases ... first comes first serves, the module will always try to grab its features from the sticky-module counterpart, no matter how bundlers will try to change that ... it's in the core of the project now (it's been weeks but ... hey ...).

Closing unless anyone is able to reproduce this issue again with current PyScript (in that case, please do re-open this issue!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

3 participants