Fix failing integration tests #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find @FabioRosado One question I have is -- Does the CI still run on changes to |
madhur-tandon
approved these changes
Nov 24, 2022
|
Thanks! I doesn't because I wasn't sure if we wanted to change CI, but from the discord I think we might haha |
antocuni
reviewed
Dec 2, 2022
| @@ -44,7 +44,6 @@ | |||
| <link rel="stylesheet" href="./assets/css/examples.css" /> | |||
| <link rel="stylesheet" href="./assets/prism/prism.css" /> | |||
| <script defer src="./assets/prism/prism.js"></script> | |||
| <script defer src="https://pyscript.net/latest/pyscript.js"></script> | |||
There was a problem hiding this comment.
uhm... I wonder whether we could/should detect the "double include" case and emit a clean error instead of doing "random things"
There was a problem hiding this comment.
yeah I think that's a good idea, I was seeing some weird behaviour on the splash screen saying that the element was already created. I'll open an issue so I don't forget to tackle this 😄
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in main have been failing since #968 was merged, this PR fixes the failing tests. Looking into it, it seems that the failures are caused by:
Not sure what's happening yet, but running
pytestmanually sees to produce different failures than when we runmake test-integration-parallel.These failures weren't also caught by our CI because it's being run only when we have changes to pyscriptjs and the above PR only changed things in the example folder