Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Tests - Examples Test #152

Closed
fpliger opened this issue May 3, 2022 · 3 comments
Closed

Initial Tests - Examples Test #152

fpliger opened this issue May 3, 2022 · 3 comments
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release epic a highlevel collection of smaller related issues tag: example Related to adding or improving examples tag: tests Related to tests

Comments

@fpliger
Copy link
Contributor

fpliger commented May 3, 2022

We need to catch up on the big (embarrassing :P ) testing debt we currently have. I'd propose that, at the very minimum, we add a quick test that runs all the examples that verify that they load without errors.

This is a meaningful indicator that, at least, major features didn't break when we add changes.
@fpliger fpliger added tag: example Related to adding or improving examples tag: tests Related to tests labels May 3, 2022
@fpliger fpliger mentioned this issue May 3, 2022
Closed
@rth rth mentioned this issue May 5, 2022
Merged
@marimeireles
Copy link
Member

marimeireles commented May 31, 2022 •
edited

I wonder if this should be closed? Or maybe we should turn it into a umbrella issues about testing?
I figure it'd be nice to have visual testing. In the Jupyter ecosystem we used galata... but the web is a whole other universe. I wonder if there are similar stuff? If anyone has opinions on good softwares for this, please feel free to chime in!

@marimeireles marimeireles added epic a highlevel collection of smaller related issues backlog issue has been triaged but has not been earmarked for any upcoming release labels Jul 7, 2022
@marimeireles
Copy link
Member

Today we had a discussion on how flimsy our testing system currently is and that's probably a priority to make it better.
Let's discuss it on the next opportunity!

@marimeireles
Copy link
Member

We already have this, so we're closing in favor to create the umbrella issue #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release epic a highlevel collection of smaller related issues tag: example Related to adding or improving examples tag: tests Related to tests
Projects
PyScript OSS
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fpliger @marimeireles