Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the test suite #601

Closed
7 tasks done
marimeireles opened this issue Jul 13, 2022 · 0 comments · Fixed by #822
Closed
7 tasks done

Improving the test suite #601

marimeireles opened this issue Jul 13, 2022 · 0 comments · Fixed by #822
Labels
epic a highlevel collection of smaller related issues tag: tests Related to tests

Comments

@marimeireles
Copy link
Member

marimeireles commented Jul 13, 2022

What kind of tests do we want?

End-to-end tests and Unit tests. We should start with unit tests and then end-to-end tests. For the Python side and JS side, both PyScript APIs directly and using our examples to test user experiences with playwright.

  • Check the DOM and the possible interactions (playwright)

    • We want to write individual tests for each individual examples
      • We want to try to do what an user would do
    • it's a good time to define which examples we want to keep in the repository and which should go to the collective
  • Check the console for messages (JS offers that, Python might)

  • We need to test the actual library (pytest for the python side, we should use plain TS for the TS side)

    • We want unit tests for each of the functions on the python side, on the TS side we should check what the objects are doing and then write unit test for them

Some things that can help us in the process of writing good code 🙂 :

Tests in depth

@madhur-tandon @antocuni @fpliger @ntoll

@marimeireles marimeireles added the needs-triage Issue needs triage label Jul 13, 2022
@marimeireles marimeireles added tag: tests Related to tests epic a highlevel collection of smaller related issues and removed needs-triage Issue needs triage labels Jul 13, 2022
@marimeireles marimeireles changed the title Improving the test suit Improving the test suite Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic a highlevel collection of smaller related issues tag: tests Related to tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant