Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Interactivity To the Py-Editor #2074

Closed
JeffersGlass opened this issue May 20, 2024 · 4 comments
Closed

Adding Interactivity To the Py-Editor #2074

JeffersGlass opened this issue May 20, 2024 · 4 comments
Labels
type: feature New feature or request

Comments

@JeffersGlass
Copy link
Member

Currently, while the Py-Editor is running its code in a web worker, there's no visual indication that the script is running. We simply disable its "play" button and then re-enable it when the script completes.

A visual indication of running scripts would be great - either a spinner, a change in color, the word running or something... not sure on the details, but an experiment is probably due.

@JeffersGlass JeffersGlass added the type: feature New feature or request label May 20, 2024
@JeffersGlass
Copy link
Member Author

These changes can likely be made in the py-editor.js plugin.

@WebReflection
Copy link
Contributor

the disabled button supposed to be that indication that something is happening and you gotta wait for the result, beside avoiding multiple run of the same code (even by accident) ... that being said, I wouldn't mind adding extra visual feedback but as I am not a designer, I have no idea what solution would be best ... any idea is welcome.

@WebReflection
Copy link
Contributor

never mind ... I see this MR goal is to fix this #2078 and I like the idea/proposal there

jdw170000 added a commit to jdw170000/pyscript that referenced this issue May 27, 2024
@WebReflection
Copy link
Contributor

A proposed fix landed 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants