Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ad a Label to the Edit Field and Text to the Run Button in the py-repl Component #75

Closed
frastlin opened this issue May 1, 2022 · 1 comment
Labels
good first issue Good for newcomers tag: styling Related to the styling of pyscript components type: feature New feature or request

Comments

@frastlin
Copy link

frastlin commented May 1, 2022

Hello,
I'm a screen reader user and noticed that the py-repl component is missing text in its button component for run. There is the multiline text field for typing code (that should also have a <label> element, then there is an empty <button></button> tag with some CSS to show the run command.

  1. Visit: the blog post with an example
  2. Select all on the page and copy, then paste into a text editor
  3. Find the text: "such as <py-script> and <py-env>."
  4. Observe that between the above text and "Since we already loaded pandas and numpy", there are just blank spaces. This is pretty much how it looks to a screen reader user.

To fix this, please add a label to the multiline input field saying something like: "Python Script Area" and text to the run button saying something like: "Run".

@antocuni antocuni added needs-triage Issue needs triage type: feature New feature or request good first issue Good for newcomers tag: styling Related to the styling of pyscript components and removed needs-triage Issue needs triage labels May 6, 2022
@fpliger
Copy link
Contributor

fpliger commented Jun 28, 2022

this should have been closed by #322

@fpliger fpliger closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tag: styling Related to the styling of pyscript components type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants