Add labels for pyrepl component #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ic-768 can you add instructions on how to test this and/or a screenshot of what it looks like? |
fpliger
added
waiting on reporter
Added a screenshot - not sure how to test other than using a screenreader to make sure that the reading works as intended. |
fpliger
removed
the
waiting on reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added labels to pyrepl code editor and run button per issue #75
The labels reference their respective components by ID using the
HTMLForattribute.They are styled to be visually hidden whilst being readable by screen-readers.
The only visible difference should be if you inspect the HTML and look for label elements, like so:
The UI is completely unaffected due to hiding the elements with CSS.
Screen readers should have no problem reading the label text and attributing it to the element referenced by ID using
HTMLFor