patch plt.show() and use AGG beneath #1023
Conversation
madhur-tandon
added
the
sprint
madhur-tandon
force-pushed
the
patch-matplotlib-show
branch
from
e4cc6a0
to
718fc92
Compare
pyscriptjs/src/main.ts
Outdated
| @@ -203,6 +203,21 @@ export class PyScriptApp { | |||
| // XXX: maybe the following calls could be parallelized, instead of | |||
| // await()ing immediately. For now I'm using await to be 100% | |||
| // compatible with the old behavior. | |||
|
|
|||
| // needed for patch inside pyscript.py | |||
| await runtime.installPackage("matplotlib"); | |||
There was a problem hiding this comment.
I'm slightly concerned about installing matplotlib all the time even if we don't need it.
What do you think about adding the patch into a try/pass instead?
pyscriptjs/src/python/pyscript.py
Outdated
| os.environ["MPLBACKEND"] = "AGG" | ||
|
|
||
| import matplotlib.pyplot # noqa: E402 | ||
|
|
||
| _old_show = matplotlib.pyplot.show | ||
| assert _old_show, "matplotlib.pyplot.show" | ||
|
|
||
|
|
||
| def show(*, block=None): | ||
| buf = io.BytesIO() | ||
| matplotlib.pyplot.savefig(buf, format="png") | ||
| buf.seek(0) | ||
| display(matplotlib.pyplot) | ||
| matplotlib.pyplot.clf() | ||
|
|
||
|
|
||
| matplotlib.pyplot.show = show |
There was a problem hiding this comment.
Perhaps we could do something like:
from contextlib import suppresswith suppress(ImportError):
import matplotlib.pyplot
_old_show = ...
That way if we can't import matplotlib we just pass.
|
Hi @FabioRosado But your concerns are valid. PS -- Jupyterlite also uses a similar kind of hack |
|
Ah apologies, I just looked at the title and didn't read the main PR text |
madhur-tandon
force-pushed
the
patch-matplotlib-show
branch
from
718fc92
to
4b77b6a
Compare
|
Closing, since we don't really need this. |
This is kinda WIP and may require improvements
But showcases how things like #983 can be fixed.