Don't add Python Plugins to Manager Twice #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python plugins were being registered with the App's plugin manager twice: once in
fetchPythonPlugins
:pyscript/pyscriptjs/src/main.ts
Lines 294 to 297 in c0f36aa
And once in the
init
method of the Python Plugin class itself:pyscript/pyscriptjs/src/python/pyscript.py
Lines 498 to 500 in c0f36aa
This PR removes the second registration, and improves
test_execution_hooks
to check that the specified hooks are called exactly once, instead of at least once.Fixes #1049