Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Pull request template #1279

Merged
merged 2 commits into from Mar 13, 2023
Merged

Added Pull request template #1279

merged 2 commits into from Mar 13, 2023

Conversation

Mr-Sunglasses
Copy link
Contributor

Added a pull request template as mentioned in the issue #1236 .

@Mr-Sunglasses Mr-Sunglasses mentioned this pull request Mar 12, 2023
Closed
@marimeireles
Copy link
Member

This looks good to me!
Pinging @FabioRosado for review cause he came up with the idea.
Thanks for the PR @Mr-Sunglasses :)

FabioRosado
FabioRosado approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks good 😄

@FabioRosado FabioRosado merged commit a2a9613 into pyscript:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioRosado FabioRosado FabioRosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mr-Sunglasses @marimeireles @FabioRosado