Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly imporved pyrepl #1296

Merged
merged 2 commits into from Mar 24, 2023
Merged

Slightly imporved pyrepl #1296

merged 2 commits into from Mar 24, 2023

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Mar 20, 2023

Description

This PR slightly simplifies some dance around py-repl component without tackling other concerns we still need to discuss. The code has been cleaned up a bit, simplified, and it should be less error prone.

Changes

  • removed unnecessary getAttribute
  • removed unnecessary shadow and ShadowDOM in general, as it was never used
  • dropped redundant constructor
  • reused addReplAttribute for both attributes
  • removed unnecessary usage of the label element + fixed redundant always-same buttons IDs

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection changed the title Slightly imporved pyrepl WIP: Slightly imporved pyrepl Mar 20, 2023
@WebReflection
Copy link
Contributor Author

WebReflection commented Mar 20, 2023

Ooops, sorry folks, marked as WIP due errors I didn't spot locally ... investigating.

edit dropped WIP

@WebReflection WebReflection changed the title WIP: Slightly imporved pyrepl Slightly imporved pyrepl Mar 20, 2023
Copy link
Contributor

@antocuni antocuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it needs rebasing.
Let me know when it's ready to be merged, thanks

pyscriptjs/src/components/pyrepl.ts Show resolved Hide resolved
@marimeireles
Copy link
Member

Cool! Thank you :)

@WebReflection
Copy link
Contributor Author

WebReflection commented Mar 24, 2023

@antocuni there were a lot of conflicts after rebase + I can't use my local repo anymore ... I hope the resolved file works as expected. I am investigating what's going on in my fork.

update I'v esolved GitHub issue and tested locally all things are fine ... if CI is happy, this is ready to be merged.

@WebReflection WebReflection merged commit c8becca into pyscript:main Mar 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants