Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] try workaround explicit for jsdelivr #1692

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[next] try workaround explicit for jsdelivr #1692

merged 1 commit into from
Sep 12, 2023

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Sep 12, 2023

Description

This MR tries to avoid the jsdelivr/jsdelivr#18528 issue for the time being.

Changes

  • explicitly point at non-existent folder structure due missing redirect in jsdelivr
  • bump patch version to wait for the CDN to catch-up on this change
  • confirm manually that https://cdn.jsdelivr.net/npm/@pyscript/core@latest ow returns, and produces, the expected result

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

@WebReflection
Copy link
Contributor Author

FYI the CDN confirmed this workaround is the correct one and they won't change the current behavior in the future so this MR is safe to land and it's ad-hoc for the best CDN we have for https://cdn.jsdelivr.net/npm/@pyscript/core

Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit 32c3fb7 into pyscript:next Sep 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants